feat: parallel #73
Open
feat: parallel #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Probably would be somewhat simpler to try 6-connected first.
|
Got the first pass not crashing. Seems slower at the moment. Will have to figure out why. Looks like this speeds the first pass up, but slows down relabeling. Probably has something to do with making the renumbering array bigger. That can probably be handled with offsets. |
william-silversmith
force-pushed
the
master
branch
from
40c3c29
to
9943790
Compare
william-silversmith
force-pushed
the
master
branch
2 times, most recently
from
2292fec
to
d8d56df
Compare
|
Managed to increase perf from 120 MVx/sec to ~280 MVx/sec with 8 cores. Something isn't right, it should scale much closer to 1:1. Some timing info from a 1GVx volume colored in with 8 copies of connectomics.npy. Some things to observe:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds parallel flag.
The relabel pass was easy, but pretty marginal in terms of the performance impact. The changes that need to be made to the core equivalence pass are kind of outrageous. It might be better to maintain two separate pieces of code for single and parallel just so there's a sane version.